fivetran / fivetran/dbt_ad_reporting

[Feature] Include platform disabling logic in vertical integrity tests

Open
#147 0 comments 0 reactions 0 assignees View on GitHub
type:enhancement
Dominant language
No language data
Stars
223
Forks
79
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing feature request for this?

- [x] I have searched the existing issues

### Describe the Feature

Currently, all of our vertical integrity data validation tests (except the geo reports) expect all possible platforms to be enabled and will therefore fail if any are disabled.

Let's include logic to dynamically handle these cases in case we want to run tests on a subset of available platforms.

### How would you implement this feature?

Use the exact same [include_list](https://github.com/fivetran/dbt_ad_reporting/blob/main/models/intermediate/int_ad_reporting__keyword_report.sql) and [enabled_package](https://github.com/fivetran/dbt_ad_reporting/blob/main/models/intermediate/int_ad_reporting__campaign_report.sql) logic and if-conditionals we use in the respective intermediate models.

### Describe alternatives you've considered

Leave it as is and only test with all platforms enabled.

### Are you interested in contributing this feature?

- [ ] Yes.
- [ ] Yes, but I will need assistance.
- [ ] No.

### Anything else?

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.