fitzgen / fitzgen/is_executable

Missing `is_symlink` check?

Open
#9 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
24
Forks
13
PR merge metrics
No merged PRs in 30d

Description

This is `is_executable` of `is_executable`: https://github.com/fitzgen/is_executable/blob/master/src/lib.rs#L90-L97
This is `is_executable` of `nushell`: https://github.com/nushell/nushell/blob/b39dda05500d92b627685b8251bfe416dc621c08/crates/nu-completion/src/command.rs#L73-L86
If you compare them you will notice that nushell has an additional `is_symlink()` check but `is_executable`'s `is_executable` does not. Is this intentional or is there potentially an unintended omission?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.