firefox-devtools / firefox-devtools/profiler

Put infrastructure in place so that we don't need to request favicons when loading a profile

Open
#953 7 comments 0 reactions 0 assignees View on GitHub
call tree discussion needs gecko patch privacy profile data
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

Currently we load favicons by computing the favicon URL from the library URL. The consequences is 1/ that the favicon is the library domain's favicon, not the tab's favicon, and 2/ that we request the favicon when the user loads a profile.

Different ways to do this:

* stop displaying icons altogether
* replace the favicons by an icon showing where the frame comes from (eg: gecko / web content / js / native)
* fetch the favicons from the addon and put them in the profile
* fetch the tab's icons from the addon and put them in the profile

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-733)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.