firefox-devtools / firefox-devtools/profiler

Marker payload data has no runtime type checks

Open
#873 3 comments 0 reactions 0 assignees View on GitHub
code maintenance markers profile data
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

When markers are loaded (from JSON) into perf, they have no runtime type checks or conversions on their contents. So while flow believes that certain fields have certain types, they don't necessarily. For example a lot of time fields are Numbers (Milliseconds) but in the JSON data are actually strings, nothing converts them from strings to numbers when they're loaded.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-721)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.