firefox-devtools / firefox-devtools/profiler

Make it easier to click samples in timeline after applying filters

Open
#859 0 comments 1 reaction 0 assignees View on GitHub
polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

After I drop samples in certain functions, or filter the stack with something, it sometimes become hard to click samples on the timeline. This is probably because the exact position I'm clicking has been filtered out, and thus the click ends up going to nothing.

If there is nothing in the timeline around the cursor at that point, that's probably expected, but when the filtered sample is just one or two which happen to be under the cursor while samples around are still there, it could be very confusing and inconvenient.

It would probably be helpful that if a click ends up falling on a filtered out sample, it picks the nearest available sample around it, and check if that sample is drawn within a certain range on the timeline (e.g. one or two px), and use it if so.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-716)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.