firefox-devtools / firefox-devtools/profiler

Provide a way to collapse non-branching call nodes in call tree

Open
#725 2 comments 0 reactions 0 assignees View on GitHub
call tree
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

![image](https://user-images.githubusercontent.com/1588648/35171731-736cbaf4-fd2a-11e7-9f9d-7e04a57de691.png)

Looking at a call tree like this is kind of unhelpful, as it doesn't show anything pertinent that is going on. It would be useful to be able to collapse non-branching call nodes in a call tree. This could be implemented as a view on the call tree, so that it could be toggleable and not affect the call tree transforms.

I'm not sure the best way to represent the collapse. Unbranched paths could have `First Function [...] Last Function` as a row, and you could click the [...] button in order to uncollapse it.

Or maybe something like:
![](https://user-images.githubusercontent.com/1588648/35172168-2a3e1bc8-fd2c-11e7-9883-56cd6a3560b8.png)

However it's implemented, this could probably be done in the CallTree component UI, maybe with a new intermediate data structure.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-689)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.