firefox-devtools / firefox-devtools/profiler

Revisit FunctionInfoResult type in profile-query library

Open
#6,270 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

`FunctionInfoResult` has a `library` property, but after #6258, a single function can have frames from multiple libraries. At the moment we return an arbitrary one. We should revisit this.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-1406)

Contributor guide

Open the contributing guide

Research direction

Start by locating FunctionInfoResult in the profile-query library and tracing its callers to understand how the library property is consumed. Review the behavior introduced by #6258; done means the result type and its consumers no longer rely on an arbitrary library when a function has frames from multiple libraries, with tests covering that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.