firefox-devtools / firefox-devtools/profiler
samples.argumentValues is present in profiles from the Gecko profiler even if tracing is off
Open
profile data
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 491
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 30
Description
STR:
1. Capture a regular profile from Firefox
2. On the web console, print `profile.threads[0].samples.argumentValues`
It's an array full of nulls.
I believe in the Gecko format we always put an "argumentValues" entry in the schema, and then geckoSamples.argumentValues will exist even if none of the samples had a non-null value, so this `'argumentValues' in geckoSamples` will always be true:
https://github.com/firefox-devtools/profiler/blob/8c0afb1f47190487b08ea2561ae3cc0f7a5d31e9/src/profile-logic/process-profile.ts#L959-L961
cc @squarewave
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-1267)
Contributor guide
Assessment
This issue has not been assessed yet.