firefox-devtools / firefox-devtools/profiler
Convert more flag-type arrays to use BitSets
Open
code maintenance
data transform
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 491
- Avg merge
- 3d 46m
- Merged PRs (30d)
- 27
Description
I was reviewing #5916 which was starting to use `BitSet`s for the `shouldKeepStack` array. Then I thought we could audit more places and see if there are other places that we can switch to it.
So far I noticed 3 places:
- `stackContainsFunc` in `dropFunction` transform
- `isInCollapsedSubtree` in `collapseFunctionSubtree` transform
- `ancestorOfCallNodeContainsFuncToCheck` in `funcHasRecursiveCall`
I didn't check fully but I think it would be nice to start with them and then convert more if we think there are more.
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-1242)
Contributor guide
Assessment
This issue has not been assessed yet.