firefox-devtools / firefox-devtools/profiler

Feature request: Commit the search filter as a transform

Open
#5,834 0 comments 0 reactions 0 assignees View on GitHub
data transform
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

I'd like to be able to "commit" the current search filter as a transform. This would push a transform and then clear the search field. This would let us "stack" multiple searches, and it would allow adding other transforms on top without accidentally dropping samples.

As for the UI, we could add a similar dropdown button like we have on the marker chart panel.

---

Example profile: https://share.firefox.dev/4aoDUSt

In this profile, I have a search filter applied. Now I want to apply some "merge function" transforms to merge away the bottom frames in the flame graph. But after merging those functions, the samples will disappear! Because the search filter currently always applies at the end, after all the transforms are applied.
If I had the option to commit the search filter, then I could commit it first, and then add the "merge function" transforms, and all the samples would remain in view.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-1004)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.