firefox-devtools / firefox-devtools/profiler

Type check the js files that have JSDocs

Open
#5,662 0 comments 0 reactions 0 assignees View on GitHub
code maintenance
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

We have files like `bin/l10n-sync.js` that have JSDocs in them, but apparently we are not checking them with `yarn ts` correctly. See my comment here: https://github.com/firefox-devtools/profiler/pull/5659#issuecomment-3498430787

It would be good to properly check them with typescript. To be able to do that I believe we need to add `"allowJs": true` to tsconfig.json, and add `// @ts-check` to these files.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-940)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.