firefox-devtools / firefox-devtools/profiler

Polish the UI for size profiles enough to be comfortable enabling it by default on the Firefox JSON Viewer

Open
#5,655 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Known issues:
- [x] the interval in the profile info panel is shown with a time unit.
- [x] the stack chart tooltips show time units (but the flame graph tooltips show correct size units!)
- [ ] the CPU percentage line in the timeline tooltip doesn't make much sense.
- [ ] the 'Call Tree' panel name doesn't make sense for a file size (and the 'Stack Chart' name might not be great either).

More generally applicable issues that were mentioned in the JSON size profiler [review](https://phabricator.services.mozilla.com/D270623#9388796):
- [x] The track selector is still there for profiles with a single track
- [ ] The empty 'Marker Chart' and 'Marker Table' panels should be hidden for profiles without markers.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-939)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.