firefox-devtools / firefox-devtools/profiler

The sidebar should start out closed on mobile for all panels, not just the panel that's visible on load

Open
#5,470 0 comments 0 reactions 1 assignee Claimed by @kala-moz View on GitHub
mobile
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

After the fix from #5464, it seems that we only change the sidebar open state for the panel that's initially selected.

Steps to reproduce:

1. Open a profile where the call tree tab is selected on load, on a mobile screen size. [Example profile, main branch](https://main--perf-html.netlify.app/public/rxabzrr1e4fcb8f05aavnbm7vsgcp4cn2hg7mtr/calltree/?globalTrackOrder=a0w9&hiddenGlobalTracks=1w8&hiddenLocalTracksByPid=4612-0w4~4636-0~4617-0&implementation=js&search=activity-s&thread=f&timelineType=category&v=10)
2. Switch to the marker table pane.

Expected results:

The sidebar should also be closed by default in the marker table.

Actual results:

Switching to the marker table tab causes the sidebar to open.

The same happens in reverse: Loading a link to `/marker-table` and switching to the call tree opens the sidebar.
Or if you load a link to the flame graph tab, switching to either call tree or marker table opens the sidebar.

@Carla-Moz

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-909)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.