firefox-devtools / firefox-devtools/profiler

Remove innerWindowID from the frameTable once the active tab view is gone

Open
#5,443 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

The frameTable has an innerWindowID column so that we can determine, per sample, whether that sample was relevant for a given page. This is what we use in the active tab view to hide samples from other tabs.

But the active tab view is going to be removed (#4997).

The replacement doesn't do any filtering of samples. The motivation for this was two-fold:

1. Firefox Desktop now puts separate origins into separate content processes ("Fission"), so by filtering processes, you also make sure that the remaining processes only contain relevant samples.
2. Even if code from different pages runs in the same process, anything within a process can be relevant to slow performance, so it's better to just show it all.

This means that the innerWindowID information in the frameTable will be unnecessary. We will need another way to know which process is relevant to which page (#5442), but with that fixed, we should just remove the innerWindowID column from the frameTable entirely.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-899)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.