firefox-devtools / firefox-devtools/profiler

Change the Chrome importer to emit schema-based markers

Open
#5,308 0 comments 0 reactions 0 assignees View on GitHub
profile data
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

The Chrome importer currently creates markers whose `data.type` doesn't match a schema. Instead, we should have a schema and then set `data.type` to the name of the schema.

The `data` object also has other properties which need to be declared in a schema, for #5302.

In [this example profile](https://share.firefox.dev/4iPMqfc), most markers just have a `category` field. But some have a lot more data. You can find them by executing `filteredMarkers.filter(m => m.data && Object.keys(m.data).length > 2)` on the console.

I'm not sure what to do about that extra data. It could be stuffed in a field called `chromeMarkerData` with a new field format called `freeform-object`.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-858)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.