firefox-devtools / firefox-devtools/profiler

Make various GC markers schema-based

Open
#5,305 0 comments 0 reactions 0 assignees View on GitHub
markers memory
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Markers with types `GCSlice`, `GCMinor` and `GCMajor` currently have custom code for their tooltips. Their fields `timings` / `nursery` / `nurseryTimings` are not declared in a schema.

We should add marker field formats for these JSON objects and declare the fields in the schema, for #5302.

So then the custom tooltip code would still be there, but it would just be called for a field whose format is e.g. `gc-minor-nursery-timings`, rather than for a marker whose `data.type` is `GCMinor`.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-855)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.