firefox-devtools / firefox-devtools/profiler

Store the profile time range in the profile, rather than computing it based on samples / markers

Open
#5,300 0 comments 0 reactions 0 assignees View on GitHub
profile data timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

When we load a profile, we compute the visible start and end time based on the sample and marker data in the profile.
It would be faster and less brittle to skip this computation.

I would say that, in all cases, the tool which creates the profile knows best for which time range it has data. So it should write that time range down in the profile.

This would also simplify our code, because we don't need to worry about caching the computed time range efficiently.
And it would fix bugs where the automatic computation gives bad results, such as #4129.
It would also make it easier to fix bugs in the uploading sanitizer, like #3518 and #3279.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-850)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.