firefox-devtools / firefox-devtools/profiler

Markers drawn in the stack chart are not very visible when they're small

Open
#5,019 0 comments 0 reactions 0 assignees View on GitHub
JS Execution Tracing
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Here is an example: https://share.firefox.dev/3x6ebx8 from https://phabricator.services.mozilla.com/D212717

I think the issue is that this was implemented by making the markers drawn by the stack chart implementation.
Instead I think we should use the marker chart implementation in its own separate canvas. The nice consequences would be that the marker design would be the same, and we'd get the context menus and tooltips (see also #2354, #2355) for free.

I don't know how hard or easy this would be though. It would need some additional investigation to estimate the complexity.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-802)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.