firefox-devtools / firefox-devtools/profiler

Misleading URL in "Collapse resource" context menu item

Open
#4,686 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Profile: https://share.firefox.dev/3XBbdcU

For JS code from the web, we create one "resource" for the entire origin, e.g. one resource for all URLs with the origin "https://abs.twimg.com". But in the context menu for collapsing a resource, it has the full URL, which is confusing.

Steps to reproduce:

1. Go to https://share.firefox.dev/3XBbdcU
1. Right-click one of the Twitter JS functions in the call tree.
1. Notice how it says "Collapse https://abs.twimg.com/responsive-web/...", i.e. it contains the full URL.
1. Click the menuitem.
1. Notice how not just that one URL, but all functions from https://abs.twimg.com have been collapsed.

Instead, the context menu item should say "Collapse https://abs.twimg.com/" with the rest of the URL omitted.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-654)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.