firefox-devtools / firefox-devtools/profiler

Switching between threads should not change the selected panel (don't hide Call Tree panel if there exists a thread with samples)

Open
#4,632 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Switching threads can get you "stuck" on the marker panel when you didn't mean to switch panels.

Steps to reproduce:

1. Load this profile: https://share.firefox.dev/3IBw8Gb
1. Click the "BHMgr Processor" thread.
1. Click the main thread again.

Expected results:
You should be back in the call tree.

Actual results:
You are now on the marker chart.

Even at step 2, the message `The marker chart is empty for “BHMgr Processor”` is not helpful - I was interested in samples, not in markers.

- - -
Hiding the call tree is useful for profiles which don't have any samples in them at all. But I think as soon as there's at least one thread with samples, we should keep the panels consistent between threads.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-643)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.