firefox-devtools / firefox-devtools/profiler

Escape ~ and - in string PIDs in the URL

Open
#4,512 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Our PIDs are strings. In URL query parameters such as `hiddenLocalTracksByPid` we include the string PID as-is and separate it from the rest of the parameter value with ~ and - characters. However, this breaks if the PID itself contains those characters.

We should escape them somehow.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-618)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.