firefox-devtools / firefox-devtools/profiler

Inconsistencies with keyboard shortcuts when call node context menu is open

Open
#4,435 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

When the call node context menu is open on various tabs, keyboard shortcuts such as arrow keys can control components other than the menu itself:

* [Call Tree](https://i.imgur.com/jKaCZtp.gif): Arrow keys are controlling the call tree instead of the context menu.
* [Flame Graph](https://i.imgur.com/J0JNh7m.gif): Arrow keys are controlling both the canvas and context menu.
* [Stack Chart](https://i.imgur.com/8U4FxGm.gif): Arrow keys are only controlling the context menu (probably coincidence, since stack chart doesn't do anything with arrow keys)

I think the expected behavior should be that shortcuts that aren't in the context menu or relating to the focused node shouldn't do anything. So up/down arrow keys should only control the context menu, and left/down should do nothing. Similarly, it also makes sense for all the shortcuts listed in the context menu to dismiss the context menu open being used, similar to how they would be if you clicked on them.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-605)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.