firefox-devtools / firefox-devtools/profiler

When loading an unsymbolicated profile with the source view open, the source does not appear once the symbols arrive and the error is cached

Open
#4,362 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Steps to reproduce:

1. Use `samply` to capture a profile.
1. Show some local source code by double-clicking a function with debug info for a local file.
1. Refresh the page.

Expected results:
As the page reloads and re-resolves symbols, the source code should appear once the symbols have arrived.

Actual results:
The source view shows "Source not available" for this file forever.

The workaround is to close the source view and refresh the page.

- - -
What happens here is that we try to show the source before we have symbols, we fail, and we cache the failed response for that file. We fail because we need an "address proof" for the local source file, and we can only find that address proof once we have symbols.

We should invalidate cached source file error responses when we get new symbols with those file names.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-598)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.