firefox-devtools / firefox-devtools/profiler

The SampleGraph should use the full thread to compute its samples

Open
#4,342 0 comments 0 reactions 0 assignees View on GitHub
polish timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Currently the SampleGraph uses the filtered thread only. This leads to some issues, especially when using the inverted tree, because the category isn't properly computed in this case.

Instead we should use the full thread to compute this information. This would also make it possible to show the filtered out samples with a different color (currently they're not displayed at all).

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-593)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.