firefox-devtools / firefox-devtools/profiler

Display [inl] badge anywhere we display stacks: tooltips, marker table sidebar, flame graph, stack chart

Open
#3,999 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

For inlined functions, the call tree displays a small "[inl]" badge in front of the function name. But in the other places where we display stacks, we do not have such an annotation yet.

Inlined functions are still present in those other stacks, they are just not annotated as such.

Florian mentioned to me that this inconsistency is confusing. People might be afraid that those other stacks are missing inlined functions completely.
We should be consistent and display it everywhere. This includes:

* [ ] Tooltips which display stacks
* [ ] The marker table sidebar, if a marker with a stack is selected
* [ ] The flame graph
* [ ] The stack chart

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-540)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.