firefox-devtools / firefox-devtools/profiler

The Chrome importer loses precision by sampling with a 0.5ms interval

Open
#3,986 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Profile: https://share.firefox.dev/3rl69ub

Chrome's profiler seems to use a 0.1ms sampling interval, at least on macOS. Importing those Chrome profiles into the Firefox profiler creates a profile that pretends to be sampled at a 0.5ms interval. This loses information.

We do the re-sampling because Chrome's format is a list of "enter function, enter function, exit function, enter function" and it's a bit tricky to convert that into samples. But since the Chrome profiling data is originally based on samples, those "exit" and "enter" events happen at the same timestamp. So we should be able to do a better job here and be able to create a sampled profile with the correct original timestamps.

I think the ART importer does this better.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-538)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.