firefox-devtools / firefox-devtools/profiler

Consider having Compare View warn the user about very different versions (i.e. possibly uncomparable)

Open
#3,521 0 comments 0 reactions 0 assignees View on GitHub
comparison polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

We wanted to know why local builds were faster than nightly builds https://github.com/mozilla-mobile/fenix/issues/18753. We took a profile from a Nightly build and a local build made from around the same commit and put them in the Compare View only to later discover that we chose the wrong builds and were comparing a July 20th build to an August 20th build. **It would be helpful if the Compare View warned you about comparing profiles that are expected to be too different from one another.** For example, if the profiles are taken on a Firefox version released more than a week apart from each other, it can pop up a dialog to notify you before showing you the diffs. It shouldn't prevent the action because perhaps you intended to look at profiles so different from one another.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-431)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.