firefox-devtools / firefox-devtools/profiler

The file size should not (only) be displayed in the Download button, to reduce the temptation for misclicks

Open
#3,478 1 comment 0 reactions 0 assignees View on GitHub
polish privacy
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Jeff M. told me that he frequently clicks the Download button instead of the Upload button when he tries to share a profile, by accident. This happens when he wants to minimize the amount of uploaded data by tweaking the profile contents with the checkboxes. After clicking the checkboxes, the file size updates and is displayed in the Download button. This seems to make it tempting to click the Download button afterwards.

However, the file size isn't really specific to Download, it applies just as much to Upload. So it probably shouldn't be inside the button at all.

![](https://user-images.githubusercontent.com/961291/128063795-d6479861-3d41-45c7-9d2e-566b1b0f9da5.png)

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-425)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.