firefox-devtools / firefox-devtools/profiler

Losing focus state when closing delete panel on /uploaded-recordings

Open
#3,406 0 comments 0 reactions 0 assignees View on GitHub
accessibility uploaded profiles
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

Steps to reproduce:

1. Go to https://profiler.firefox.com/uploaded-recordings/ (and have at least one uploaded profile).
1. Tab through the document until a Delete button is focused.
1. Press space to open the confirmation panel.
1. Press tab to put focus inside the confirmation panel.
1. Press escape.

Expected results:
The delete button should stay visible and be focused.

Actual results:
Focus is lost and the delete button disappears.

This is probably a regression from #3083. Maybe we need an `onWillClose` notification so that focus can be moved before the panel is fully closed.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-415)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.