firefox-devtools / firefox-devtools/profiler

Nothing is displayed when zooming between two samples

Open
#3,332 0 comments 0 reactions 0 assignees View on GitHub
timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

From @julienw's comment on #3319:

> I still found an issue when zooming in between 2 samples:
> 1. [start from this link](https://profiler.firefox.com/public/07ssba14pm3vnacv8fcfjtnnban4hwvfqxzag90/calltree/?globalTrackOrder=12-0-1-2-3-4-5-6-7-8-9-10-11&hiddenGlobalTracks=1-2-3-4-5-6-7-8-9-10-12&localTrackOrderByPid=36639-2-3-0-1~36653-0~36646-0~36649-0~36650-0~36664-0~36648-0~39224-0~36652-0~39238-0~36651-0~39254-0-1~&range=3438m650~3438m202~3438m56~3456004u8979~3463089u1035&thread=0&timelineType=cpu-category&v=5)
> 2. Select and commit a range between the 2 samples.
>
> => then nothing is displayed, but I believe we should still see something?

I agree that normally we should still be able to see the previous and next sample, even though these samples are not exactly inside the time range.
This wasn't possible before because we were directly using the filtered thread to the activity graph. But now, we are also sending the full thread to the activity graph. This should now be possible to render the samples even though they are not exactly in the view.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-392)

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue from the linked profiler profile by selecting and committing a range between two samples. Start with the activity graph's handling of the full thread and selected time range; done means the previous and next samples are still rendered when they fall just outside the range.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.