firefox-devtools / firefox-devtools/profiler

Add a test for searching in marker's categories

Open
#3,309 0 comments 0 reactions 0 assignees View on GitHub
code maintenance tests
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

In #3299, searching for the marker's categories was implemented, but not test was added because it was a bit too difficult for a contributor.

New tests will be in `src/test/store/profile-view.test.js`, around `describe('changeMarkersSearchString')`. However our current tests don't make it easy to use some non-zero categories for markers, so we need to change how we add markers to profiles in tests.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-384)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.