firefox-devtools / firefox-devtools/profiler

Localize `additionalMessage` from `ProfileRootMessage`

Open
#3,230 0 comments 0 reactions 0 assignees View on GitHub
i18n polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

We need a clever idea to localize `additionalMessage`:

Currently this comes from various locations:

* temporary errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/reducers/app.js#L27-L34
* fatal errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/components/app/AppViewRouter.js#L86-L91

Also `ProfileRootMessage` is used in different locations (`ProfileLoaderAnimation` and `AppViewRouter`), as is `ProfileLoaderAnimation` (both `UrlManager` and `AppViewRouter`). Probably we should simplify this, because currently it's quite difficult to understand which flow is used in which situation.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-368)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.