firefox-devtools / firefox-devtools/profiler

Limit the sample length to interval on the activity graph when there are no samples after/before

Open
#3,212 0 comments 0 reactions 0 assignees View on GitHub
timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

In the activity graph, samples extend more than they should when there are no samples before or after that one.
For example:

![](https://user-images.githubusercontent.com/466239/110505055-18241b00-80fe-11eb-9652-eecb6e4e43de.png)
There are no samples in the area that is marked, as you can see in the sample graph below. So, this are should left blank (or have another indicator), so people can actually see the that there is no activity in that area. Currently it looks like it's previous and next samples are looking a lot longer than they actually are.

So as a solution, we should limit the sample length to intervals. This is not necessarily correct either but at least it's more accurate compared to the current visualization

[Example profile](https://deploy-preview-3098--perf-html.netlify.app/public/rvh0n155hj416h23abtfynzzxyhabsyx2rqnzk0/calltree/?globalTrackOrder=0-1-2-3-4-5-6-7-8-9-10-11-12&localTrackOrderByPid=96008-13-14-0-1-2-3-4-5-6-7-8-9-10-11-12~96010-0~96021-0~96020-0~96011-0~96019-1-0~96017-2-0-1~96014-1-2-0~96018-1-0~96015-1-2-0~96016-1-2-0~96013-3-4-0-1-2~96012-1-2-0~&range=3637m756&thread=17&timelineType=cpu-category&v=5)

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-364)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.