firefox-devtools / firefox-devtools/profiler

Make WindowTitle component localizable

Open
#3,207 2 comments 0 reactions 0 assignees View on GitHub
i18n
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

This component is a bit different than the others. I think that's why it deserves its own issue. It doesn't have anything in it's render function. But it changes the title of the window on every `componentDidUpdate` or `componentDidMount`.
I don't think everything there is localizable, but we can at least make the page titles localizable (like "Uploaded Recordings", "Compare Profiles", or "Zip File Contents")

Currently, most of the time, we are using the fluent `Localized` declarative API. But for this case, we might need the imperative APIs. Or we can consider using `react-document-title` package with `Localized` as suggested here: https://github.com/projectfluent/fluent.js/wiki/Localized#declarative-and-imperative-apis

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-363)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.