firefox-devtools / firefox-devtools/profiler

New layout for the marker chart: Display stack-based markers in a stack-chart-like layout

Open
#3,141 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

I'd like to propose two changes:

1. For each marker type, the profiler should know whether markers of that type are "stack-based" or not. Probably with a new flag in the schema.
1. In the marker chart, all stack-based markers should be collected in one section of the chart, and not split into separate rows by type. This will display them in a layout that looks similar to the stack chart: markers that "run" further to the root of the stack will be at the top, and nested markers that run during those calls will displayed underneath. Markers of different types will share the same row, based on their nesting depth. The other, non-stack-based, markers can keep their own rows.

This will make it a lot more obvious "what's happening" at any given time on the selected thread. It eliminates the need to scroll down to find a marker that runs during the time that the user is looking at.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-357)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.