firefox-devtools / firefox-devtools/profiler

Consider keeping the deploy preview URLs when publishing & shortening

Open
#3,121 6 comments 1 reaction 0 assignees View on GitHub
polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

We have a check while shortening that converts back all non profiler.firefox.com urls:
https://github.com/firefox-devtools/profiler/blob/6b0146209d963aaa1154a9777b71a9125f5b822b/src/utils/shorten-url.js#L13-L19

I think this is useful when we are working on `localhost`, but I don't think this is exactly what we need for deploy previews. When I'm working on a deploy preview, I usually want to preserve the deploy preview URL when publishing, so I can send it to other people. But this check is making it impossible. So in that case, we resort to sending the long urls which is annoying most of the time, since the url can be very long.

So to solve this issue, it would be good to add an exception for deploy preview URLs.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-353)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.