firefox-devtools / firefox-devtools/profiler

Double-clicking a "clipped" marker in the marker chart sets an inconsistent range selection

Open
#3,034 0 comments 0 reactions 0 assignees View on GitHub
timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

Steps to reproduce:

1. Load this profile: https://share.firefox.dev/3l11QiD
1. Notice that it's showing a zoomed-in view, where the first CompositorScreenshot marker is mostly cut off by the displayed range. Only the "end part" of the first CompositorScreenshot marker is visible.
1. Double-click that clipped CompositorScreenshot marker.

Expected results:
The preview selection should be clamped so that it's contained in the displayed range. Also, resizing the preview selection from its "start" handle should work normally.

Actual results:
The preview selection "escapes" the displayed range, and is displayed incorrectly: In the tracks list, the preview selection is overlay is set to the full width of the unclipped CompositorScreenshot marker but shifted over to the right, so that it starts at the start of the displayed range. Once you grab the "start" handle of the preview selection and move it, the "end" of the preview selection jumps to where it should be.

This problem also happens when clicking a screenshot in the screenshot track.
This problem does not occur when clicking a marker in a marker track at the top.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-336)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.