firefox-devtools / firefox-devtools/profiler

Misleading times displayed in the flame graph, should show number of samples instead

Open
#2,962 17 comments 0 reactions 0 assignees View on GitHub
flame graph ready user-facing regression
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Profile: https://share.firefox.dev/341Msw7

This is a profile where the profiler was not able to obtain a lot of samples.
When hovering over boxes in the flame graph, I see some very large times displayed. It seems these times are computed by multiplying the sample percentage with the duration of the selected range? That's rather misleading. Let's display the raw sample counts instead.

Steps to reproduce:

1. Load the profile. https://share.firefox.dev/341Msw7
1. Hover the function NtGdiDdDDIMakeResident (in the middle at the top).

Expected results:
The tooltip should display "22 samples (13%)", just as in the call tree.

Actual results:
The tooltip displays "4,053ms (13ms)".

![](https://user-images.githubusercontent.com/961291/118544476-75060800-b723-11eb-88ef-e27c7756116f.png)

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-328)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.