firefox-devtools / firefox-devtools/profiler

Do not create a new Set for selectedThreadIndexes if we are selecting the same track

Open
#2,787 0 comments 0 reactions 0 assignees View on GitHub
code maintenance perf polish timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

After #2706 and #2752, we are now keeping a `Set` for selected thread indexes. But `selecTrack` (and possibly `selectActiveTabTrack`) ThunkAction should not dispatch `SELECT_TRACK` action when we are clicking the same track. Currently it's creating a new Set object and dispatching that, which causes to miss the caches.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-310)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.