firefox-devtools / firefox-devtools/profiler

Handle clicking the activity graph for multiple selections of threads

Open
#2,709 0 comments 0 reactions 0 assignees View on GitHub
polish timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

For issue #88 of adding multiple selection, PR #2706 is not handling sample clicking in the activity graph and stack graph.

This work would need to create a mapping from the original thread call nodes to the merged thread call nodes, and take the sample, and map it to the merged space. I'm not sure it's worth changing the rendering of the ActivityGraph or not, as the filtering pipelines are different.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-298)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.