firefox-devtools / firefox-devtools/profiler
Inconsistent application of multiple search terms
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 491
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 30
Description
In the search fields in our various panes, you can use commas to search for multiple strings. However, it seems that different panes have different interpretations of "searching for multiple strings":
* If I search the call tree for `addon,extension`, I only get call stacks where both the string "addon" _and_ the string "extension" is present in the stack: https://perfht.ml/2QjbZtB
* If I search the marker chart for `ipcin,display`, I get markers that match just one of the terms: https://perfht.ml/2QmNlrU
Please choose either OR or AND and make it consistent.
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-248)
Contributor guide
Research direction
Compare how comma-separated terms are handled in the call tree and marker chart search fields, using the linked examples as behavioral references. Decide whether consistent matching should use AND or OR, apply that choice across the affected panes, and verify that both searches produce the same interpretation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100