firefox-devtools / firefox-devtools/profiler

Handle right clicked markers in the UserTimings in the stack chart

Open
#2,354 3 comments 0 reactions 0 assignees View on GitHub
polish stack chart
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

The current architecture of the right clicking makes it difficult to have one chart that handles both call nodes and markers. This is because of the way the markers use an "id" to trigger showing the context menu, and needing to embed a trigger component. I think it would be better to have a single context menu trigger that can handle both the call nodes and markers, then have a connected component decide which one to show. This would simplify the triggering method, and make it easy to do both in one chart.

I recommended not doing this initially with #2345, but it should be a follow-up for this feature. Currently the stack chart does not support right clicking markers.

[Example user Timing stack chart profile.](https://profiler.firefox.com/public/88cfc857c71be6a1678ea8ad1e31c9689b4fcc2f/stack-chart/?globalTrackOrder=0-1-2-3-4-5&hiddenGlobalTracks=2-3-4&hiddenLocalTracksByPid=26705-1-2-3&localTrackOrderByPid=26705-4-5-0-1-2-3~26837-0~26706-0~26728-0~26729-0~26752-0-1~&range=3.2983_4.9369&showUserTimings&thread=9&v=4), this requires #2345 to be merged to see the UI.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-225)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.