firefox-devtools / firefox-devtools/profiler

[no sample mode] remove tabs / switch to the marker chart by default

Open
#2,285 2 comments 0 reactions 0 assignees View on GitHub
polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

If there's no sample at all in a process, we should remove tabs that are related to the samples: call tree, flame graph, stack chart.
Probably we'll need to adjust some default values, because I think we select the call tree panel by default if no panel is selected. I think this is: https://github.com/firefox-devtools/profiler/blob/e4e91da24097099849249666960d169321a0c026/src/app-logic/url-handling.js#L36. Maybe we should keep the tabslug as null and handle it elsewhere. Or if we request 'calltree' but it's absent change it elsewhere.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-211)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.