firefox-devtools / firefox-devtools/profiler

Add a toggle option to view unmangled asm.js & wasm C++ callstacks in profiling view?

Open
#211 1 comment 1 reaction 0 assignees View on GitHub
quantum flow
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

Profiling [Zen Garden](http://mzl.la/webassemblydemo) demo with gecko profiler shows C++ function names as mangled:

![geckoprofiler!UNITO-UNDERSCORE!zengarden](https://cloud.githubusercontent.com/assets/225351/24192587/2496dd86-0ef8-11e7-950b-ac99990c5097.png)

Currently the built-in Firefox devtools performance profiler displays these C++ callstacks as demangled:

![devtoolsprofiler!UNITO-UNDERSCORE!asmjs](https://cloud.githubusercontent.com/assets/225351/24192637/4cfe96e2-0ef8-11e7-9ce3-219e5972d7b2.png)

which is really nice and a bit more readable. It would be cool to have the same feature in perf.html, however that feature would be best to live behind a checkbox (default enabled), because it is often useful also to be able to select and copy-paste mangled function names from the profiler to a text editor to search for the hot function in compiled code, so unconditionally always showing unmangled C++ function names would lose that ability.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-171)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.