firefox-devtools / firefox-devtools/profiler

We don't display the phases in the chart when missing some timings

Open
#2,021 0 comments 0 reactions 0 assignees View on GitHub
network panel polish
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

See this profile: https://perfht.ml/30oH2HW

The first requests don't have the timings 'requestStart', 'responseStart', 'responseEnd', and as a result we don't display properly the phases in the row. The existing code was made by assuming we always had these timings, and this is clearly a wrong assumption here. So we'll need to find a better algorithm that can also handle these cases.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-154)

Contributor guide

Open the contributing guide

Research direction

Open the linked performance profile and inspect the chart rows for the initial requests that lack requestStart, responseStart, and responseEnd. Trace the chart rendering entry point from that reproduction and determine how phases are currently derived. Done means rows display the available phases correctly even when those timings are missing.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
data-visualization, frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.