firefox-devtools / firefox-devtools/profiler

Remove setTimeout from ArrowPanel

Open
#1,905 0 comments 0 reactions 0 assignees View on GitHub
code maintenance
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 46m
Merged PRs (30d)
27

Description

This is a follow-up to #1852.

The ArrowPanel has an animation, and some timing logic uses `setTimeout`. In review, Julien suggested:

> Also I think we can replace the whole dance you're doing with the setTimeout and the states with the react-transition-group library: there are these properties mountOnEnter and unmountOnExit that do exactly that.
> Not blocking this PR but doable as a follow-up. I think this would simplify this component a lot. But working with that library is sometimes frustrating when we're not used to it.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-140)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.