firefox-devtools / firefox-devtools/profiler
The view not being exactly the same when sharing a profile is confusing
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 491
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 30
Description
(This issue is from feedback I got from someone in another team.)
When sharing a profile, the person opening the profile will see something that doesn't exactly match what the person sharing the profile was looking at. This can make the discussion between the engineer who shared the profile and the engineer who received it confusing.
I think the differences are mostly about which nodes are open and which row is selected in the Call Tree panel.
I guess the best solution would be to include all the information in the shared URL so that loading the URL shows exactly the same thing as what the sharer was looking at. This may require a lot of effort though, so maybe a workaround to avoid the confusion could be to reset the call tree view at the time we show the tiny url, so that the sharer sees what the receiver will see and doesn't have incorrect expectations about what is being included in the shared URL.
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-79)
Contributor guide
Research direction
Begin by tracing the shared URL creation and loading flow, then inspect how the Call Tree panel stores expanded nodes and the selected row. Done means either the shared URL restores the same view or the sharing flow resets the view so both users see the same state; the issue does not name specific files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, redux, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100