firefox-devtools / firefox-devtools/profiler

Display vsync markers in the marker timeline at the top, as vertical lines across all threads

Open
#1,348 3 comments 0 reactions 0 assignees View on GitHub
timeline
Dominant language
TypeScript
Stars
1.5k
Forks
491
Avg merge
3d 5h
Merged PRs (30d)
30

Description

We now have `VsyncTimestamp` markers displayed in the marker chart, for example in this profile: https://perfht.ml/2EdNp9K

However, it's still hard to track vsync timing across threads. It would be more useful to also have vertical lines in the thread timeline at the top, across all threads.

I'm not sure how exactly this should look. We already have faint grey grid lines up there; adding more lines may make things look really busy. We probably also need a zoom threshold; if you're zoomed out enough that each line would only be 3 pixels or less apart, we should probably hide the lines completely.

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-73)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.