firefox-devtools / firefox-devtools/profiler
Clean up the argument ordering of initializeLocalTrackOrderByPid and initializeGlobalTrackOrder
Open
code maintenance
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 491
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 30
Description
This is a review follow-up from #1241
> I see that the logic in initializeLocalTrackOrderByPid and initializeGlobalTrackOrder is similar but the order of the initial condition about legacyThreadOrder is different. This made it a bit difficult for me to check if the changes in these 2 functions were correct.
> Maybe in initializeGlobalTrackOrder we could start with if (legacyThreadOrder === null), as a symmetry to initializeLocalTrackOrder.
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FP-62)
Contributor guide
Assessment
This issue has not been assessed yet.