firecracker-microvm / firecracker-microvm/firecracker
[Feature Request] Create integration test for testing snapshot restore on CPUs with different TSC frequencies.
- Dominant language
- Rust
- Stars
- 36.7k
- Forks
- 2.6k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 58
Description
# Feature Request
Create integration test for testing snapshot restore on CPUs with different TSC frequencies.
## Describe the desired solution
Create a integration test to validate this code: https://github.com/firecracker-microvm/firecracker/blob/f2f8802122cf20fa043600290dcc938c96b9611d/src/vmm/src/builder.rs#L482
## Describe possible alternatives
We need 2 things for this:
* a snapshot saved on S3 on a CPU that has a certain TSC frequency
* an integration test that is being run on a CPU with a different frequency
`[Author TODO: How do you work around not having this feature?]`
## Additional context
`[Author TODO: Add additional context about this feature request here.]`
## Checks
- [x] Have you searched the Firecracker Issues database for similar requests?
- [x] Have you read all the existing relevant Firecracker documentation?
- [x] Have you read and understood Firecracker's core tenets?
Contributor guide
Research direction
Start in src/vmm/src/builder.rs around the linked snapshot-restore code, then inspect the existing integration-test setup and snapshot storage tests. Determine how to provide a snapshot saved on S3 from one TSC frequency and run restoration on a CPU with another; done means an integration test validates the restore path across differing frequencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100